Skip to content

fix(android): resolve notification media button double-dispatch and state decoupling #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyrindev merged 1 commit into from
Oct 3, 2026
Merged

fix(android): resolve notification media button double-dispatch and state decoupling #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions android/src/main/kotlin/dev/wyrin/flutter_media_session/FlutterMediaSessionService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,48 +275,6 @@ class FlutterMediaSessionService : MediaSessionService() {
}
}

override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
if (intent != null && Intent.ACTION_MEDIA_BUTTON == intent.action) {
// Satisfy the 5-second foreground requirement for MediaButtonReceiver on API <= 30
if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.R) {
ensureForegroundServiceLegacy()
}
val keyEvent = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
intent.getParcelableExtra(Intent.EXTRA_KEY_EVENT, android.view.KeyEvent::class.java)
} else {
@Suppress("DEPRECATION")
intent.getParcelableExtra(Intent.EXTRA_KEY_EVENT) as? android.view.KeyEvent
}
if (keyEvent != null) {
handleMediaKeyEvent(keyEvent)
}
}
return super.onStartCommand(intent, flags, startId)
}

/**
* Posts a minimal foreground notification on API <= 30 when started by MediaButtonReceiver
* to fulfill the Android framework requirement.
*/
private fun ensureForegroundServiceLegacy() {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) return
try {
val channelId = "default"
val nm = getSystemService(Context.NOTIFICATION_SERVICE) as android.app.NotificationManager
if (nm.getNotificationChannel(channelId) == null) {
nm.createNotificationChannel(
android.app.NotificationChannel(channelId, "Media playback", android.app.NotificationManager.IMPORTANCE_LOW)
)
}
val notification = android.app.Notification.Builder(this, channelId)
.setSmallIcon(applicationInfo.icon)
.build()
startForeground(1001, notification)
} catch (e: Exception) {
android.util.Log.w("FlutterMediaSession", "ensureForegroundServiceLegacy failed: ${e.message}")
}
}

override fun onGetSession(controllerInfo: MediaSession.ControllerInfo): MediaSession? {
return mediaSession
}
Expand Down
Loading