Repository navigation
Use GetPendingCount for the pending jobs gauge - #86
Open
shreyaabaranwal wants to merge 1 commit into
Open
shreyaabaranwal wants to merge 1 commit into
shreyaabaranwal wants to merge 1 commit into
Conversation
Contributor
|
That's a nice spot! Makes sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dbtl_queue_pending_jobsgauge added in #84 callsBroker.GetPending()onevery scrape and uses
len()of the result. On the Redis broker that isLRANGE queue 0 -1, so each scrape pulls every pending job payload just tocount them.
tasqueue v2.3.0 (already the version in go.mod) has
GetPendingCount()on theBrokerinterface, which is anLLENon Redis.GetPending()is also markeddeprecated in the interface. This switches the gauge to
GetPendingCount().The value is unchanged:
LLENandlen(LRANGE 0 -1)return the same count,and ETA-scheduled jobs are still excluded. The NATS broker returns an error for
both methods, so there's no behaviour change there either.
go buildandgo vetare clean. The client tests need a running server, so I've left them to CI.