Repository navigation
Update miniaudio to v0.11.25 - #17
Merged
Merged
Conversation
ma_engine_config gained resourceManagerResampling and pitchResampling fields (two ma_resampler_config, 96 bytes total) in v0.11.24. Without these fields the C init function overwrites past the Zig struct, corrupting the stack.
ma_sound_config also gained a pitchResampling field (ma_resampler_config, 48 bytes) between pEndCallbackUserData and initNotifications in v0.11.24. Same class of bug as the Engine.Config fix — C init function overwrites past the Zig struct without this field.
ma_sound_seek_to_second takes float (f32) in C, but the Zig extern declared f64, causing the value to be misinterpreted at the FFI boundary. zaudioAudioBufferConfigInit declared ma_int64 for size_in_frames but ma_audio_buffer_config_init expects ma_uint64.
thedaneeffect
changed the title
v0.11.25
thedaneeffect
changed the title
v0.11.25miniaudio to v0.11.25
There was a problem hiding this comment.
Pull request overview
Updates the bundled miniaudio dependency to v0.11.25 and aligns zaudio’s Zig/C ABI surface with upstream changes introduced in miniaudio v0.11.24+.
Changes:
- Bump documented bundled miniaudio version to v0.11.25.
- Fix
Engine.Config/Sound.Configextern struct layouts to include newma_resampler_configfields for resource-manager and pitch resampling. - Correct ABI mismatches in extern function/parameter types (
ma_sound_seek_to_secondusesfloatand audio buffer frame counts are unsigned 64-bit).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/zaudio.zig | Updates extern struct layouts and corrects ma_sound_seek_to_second signature to match upstream (float). |
| src/zaudio.c | Fixes zaudioAudioBufferConfigInit frame-count parameter type to ma_uint64 to match miniaudio. |
| README.md | Updates the stated bundled miniaudio version to v0.11.25. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Engine.ConfigandSound.Configstruct layouts for fields added in v0.11.24 (ma_resampler_configfor pitch/resource manager resampling)ma_sound_seek_to_secondextern declared asf64but C takesfloatzaudioAudioBufferConfigInit(ma_int64→ma_uint64)Closes #16
Test plan
zig build testpasses on macOS (arm64)zig build testpasses on Linux (arm64, Docker)