Repository navigation
Release dev → main: fix the db migrations check (count cards migrations from the journal) - #161
Merged
Merged
Conversation
0034_builder_recaps (77d2389) added the 35th cards migration but left the network test asserting 34 rows in drizzle.__cards_migrations, so the migrations workflow failed on the dev -> main PR (#160). The assertion is about applying twice recording each migration once, so compare against the journal's entry count; the next migration won't break it again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #160, which was merged before this fix landed.
Why
The
dbworkflow'smigrationsjob has been failing since0034_builder_recaps(77d2389). That commit added the 35th cards migration, butpackages/db/test/cards-network-sql.test.tsstill expected exactly 34 rows indrizzle.__cards_migrations. #160 merged with this check red.Change
readJournal(migrationsFolder('cards')).entries.length), not a hard-coded number. The check exists to prove that applying the migrations twice records each one once, and the next migration won't break it again.mainback intodev, which changes no files.The change is test-only: no migration, schema or app code changes, and nothing is applied to any database.
Verified
dbworkflow ondevat 32bb5e3: success (run 41383098275).packages/dbnpm testgave 28 pass, 0 fail and 0 skipped.🤖 Generated with Claude Code