Conversation
…om Nuxt The dev-only middleware in nuxt/server/middleware/legacy.ts decides per request whether Nuxt answers or the 11ty dev server does. Eight migrated sections were never added to it, so `npm run dev` kept serving the old 11ty page while the Netlify preview and CI, which never run this middleware, looked correct. Three sections keep assets in the 11ty tree that only reach nuxt/public through the passthrough in a production build, so they need the same carve-out /vs and /resources already had: /events/images, /landing/images and /whitepaper/images, plus the one .ics the Hannover page links. /node-red is a plain prefix now that its index is a Nuxt page, which retires the carve-out that used to keep just that path on 11ty.
✅ Deploy Preview for flowfuse-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@dimitrieh I think this should be addressed individually on each pr you opened for migrating each route. |
|
Agreed, closing. Moving each route's registration into its own migration PR. One sequencing note that motivated collecting them, so it is not lost: registering a section only works once that section's pages exist, so each edit belongs with the PR that adds them, which is what you are asking for. The flip side is that all eight touch the same two lines of Carrying over with them: |
2 participants
Description
nuxt/server/middleware/legacy.tsdecides, per request, whether Nuxt answers or the request is proxied to the 11ty dev server. It is dev-only (if (process.env.NODE_ENV !== 'development') return), so nothing in CI or a Netlify deploy preview exercises it.That is why this drifted: eight migrated sections were never added to it, and every reviewer checking a deploy preview saw a correct page while
npm run devkept serving the old 11ty one.Registers
/use-cases,/industries,/platform,/partners,/events,/landing,/blueprintsand/node-red.Three of them keep assets in the 11ty tree that only reach
nuxt/publicthrough the passthrough during a production build, so they need the carve-out/vsand/resourcesalready have:/events/images,/landing/imagesand/whitepaper/images, plus the one.icsthe Hannover page links. The/whitepaper/imagesone is what makes the whitepaper covers render on the use-case pages locally./node-redbecomes a plain prefix now that its index is a Nuxt page, retiring the carve-out that used to keep just that one path on 11ty.Merge this last. Registering a section before its migration PR lands points dev at a Nuxt page that does not exist yet.
/industriesis the live example:nuxt/pages/industries/automotive.vueis already on main while the other industry pages are still 11ty-only, so this is only correct once #5781 has merged. Same for the other seven.No test:
legacy.tsis deleted by #5795 in this same epic, so a regression test for it would be born dead.Verified by simulating the middleware's decision against the real constants for 20 routes, including that the
/whitepaper/imagescarve-out does not swallow real whitepaper pages, and that/aboutstill falls through to 11ty since #5791 registers that itself.Related Issue(s)
#5777
Checklist