Repository navigation
fix(validation): base the validation summary on applied signatures only - #9009
Merged
vitormattos merged 2 commits intoOct 21, 2026
Merged
Conversation
YvesCesar
self-requested a review
October 17, 2026 17:06
YvesCesar
requested changes
Oct 17, 2026
YvesCesar
approved these changes
Oct 20, 2026
YvesCesar
left a comment
Member
There was a problem hiding this comment.
Many thanks, @maia-andre !
@vitormattos looks okay to me.
I don't think the errors in the pipelines are related to the PR.
The validation page showed "This document is valid" for a document that nobody has signed yet, and for an envelope where nobody signed. The summary only returned "No digital signatures were found in this document" when the signer list was empty; a pending signer carries no signature data, so none of the error or warning checks matched and the summary fell through to "valid". The summary now considers only the signers who have signed (a signing date or signature validation data). When nobody has signed, it shows the existing "No digital signatures were found" note; otherwise the current checks run on the signed signers only. Fixes LibreSign#8967 Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: André Maia <andrefnkmm@gmail.com>
…e summary Signed-off-by: André Maia <andrefnkmm@gmail.com>
vitormattos
force-pushed
the
fix/validation-summary-unsigned-8967
branch
from
October 21, 2026 01:09
d02d24b to
24d5a9c
Compare
Member
|
/backport to stable35 |
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #8967
📝 Summary
The validation page showed "This document is valid" for a document nobody has signed yet, and for an envelope where nobody signed.
getDocumentValidationSummary()insrc/views/Validation.vueonly returned "No digital signatures were found in this document" when the signer list was empty. A pending signer carries nosignature_validation,modification_validationordocument_modification_state, so none of the error or warning checks matched and the summary fell through to "valid".The summary now considers only the signers who have signed, meaning a signer with a signing date or with signature validation data:
The same function feeds the header note for single files and envelopes, so both are covered. No new strings.
🧪 How to test
/apps/libresign/p/validation/<uuid>(logged out is fine).🎨 UI changes
Signed document, unchanged:
Vitest cases in
src/tests/views/Validation.spec.ts: nobody signed, envelope where nobody signed, only signed signers are evaluated, and a signer with a signing date but no cryptographic details. Local runs:npx vitest run src/tests/views/Validation.spec.ts src/tests/views/DocumentValidationLogic.spec.ts(116 passed),npm run ts:check, eslint on the changed files.Backport
The same logic is on
stable33,stable34andstable35, and the commit cherry-picks cleanly onto them.stable32has older code that sets "This document is valid" unconditionally, so this change does not apply there as is.✅ Checklist
🤖 AI (if applicable)