Repository navigation
build(deps): update 3rdparty pdfparser to 2.13.1 - #9187
Merged
Merged
Conversation
Point the submodule to the merged LibreSign/3rdparty PR #110. Fix PDF font Encoding parsing for Header and PDFObject cases. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the LibreSign
3rdpartysubmodule to the merge commit of LibreSign/3rdparty#110, which upgradessmalot/pdfparserfrom 2.12.5 to 2.13.1.Related to #7706 and the follow-up PDF parsing error in #3949.
Verification
3rdpartyrepository.Header) and Font::getDetails() throws TypeError when Encoding is indirect reference to PDFObject smalot/pdfparser#822 (indirectPDFObject) throw onFont::getDetails(). With 2.13.1, both pass, as does a regular PDF (PHP 8.3).3rdpartychecks and the signed/DCO commit were verified separately. LibreSign CI for this PR is pending.Limit: The original HTTP 422 endpoint was not reproduced end-to-end; the underlying parser exceptions were reproduced and resolved with the updated package.