Repository navigation
chore: TypeScript 7 - #331
Merged
Merged
Conversation
Every workspace package takes typescript from a shared catalog:tooling entry at ^7.0.2, as Maple does. apps/web and apps/docs drop baseUrl, which TypeScript 7 removed (their paths are relative already). apps/ landing stays on 5.9: astro check runs the Astro language server, which needs the TypeScript JS API the native compiler does not ship. Under 7 a concrete PG.insertInto(table) is assignable to effect-orm's Runnable again, so @hazel/db's widened Runnable workaround is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (31)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #330. Moves the workspace to TypeScript 7 (
typescript@7.0.2, the native compiler), as Maple already does.Changes
typescriptfrom a sharedcatalog:toolingentry (^7.0.2). Before, each package pinned its own 5.9.x.apps/web,apps/docs: dropbaseUrl, which TS 7 removed. Theirpathsare relative; docs'.source/*becomes./.source/*.apps/landing: stays on TypeScript 5.9.astro checkruns@astrojs/language-server, which calls the TypeScript JS API (ts.findConfigFile), and the native compiler doesn't ship that API. Move it once Astro supports TS 7.Testing
turbo run typecheckpasses all 19 tasks; the alchemy config typechecks clean.apps/webandapps/docs(vite build) andlibs/bot-sdk(tsdown, including.d.tsoutput) all succeed.vitestpasses 286 of 286 across 41 files (backend, cluster, electric-proxy, bot-gateway, db, backend-core, auth, domain), including the real-Postgres integration tests.apps/docshas no typecheck task. Runningtscon it shows the same 14 errors on 5.9 and on 7, so they predate this change.Note
TS 7 doesn't load tsconfig
plugins, so the@effect/language-servicediagnostics thatreportSuggestionsAsWarningsInTscadded totscoutput no longer run. The plugin entries are harmless and still used by editors on the TS 5 language service. Maple restores those diagnostics with@effect/tsgo; that can be a follow-up here.🤖 Generated with Claude Code