Repository navigation
Add annual min/max vegetation fraction to RRFS - #1626
Conversation
@BenjaminBlake-NOAA Your UPP standalone test results look good to me. Both fields VEGMIN and VEGMAX are generated with non-missing values in the 2DFLD dataset. |
|
@gspetro-NOAA This PR is ready for the UPP RTs on RDHPCS. There should be no baseline changes expected. |
@WenMeng-NOAA Thanks for running the RTs on WCOSS2! Since this change only affects the RRFS output at forecast hour 0, there are actually no baseline changes expected. |
@BenjaminBlake-NOAA Thanks for catching typo. |
gspetro-NOAA
left a comment
There was a problem hiding this comment.
All tests passed without baseline changes on Ursa (both compilers), Hercules, and Orion.
|
This PR is ready for merging. |
Resolves issue #1625
The annual min/max vegetation fractions fields in the RRFS f00 2DFLD GRIB2 files are 0 everywhere. That is because the corresponding variables shdmin and shdmax were not being read in from the RRFS model history files. This PR updates INITPOST_NETCDF.f to read in shdmin and shdmax for RRFS. I also fixed a couple of typos that I found in nearby comments.
There are no baseline changes to the UPP RTs since this only affects the RRFS output at forecast hour 0. I ran a standalone RRFS test using f00 model output and my run directory is here on Cactus:
/lfs/h2/emc/vpppg/noscrub/Benjamin.Blake/upp-pr1626-vegminmax/rrfs_2026102010
These changes will be included in a future RRFSv1.1 update. Tagging @AndrewBenjamin-NOAA and @MatthewPyle-NOAA for awareness.