Skip to content

Add annual min/max vegetation fraction to RRFS - #1626

Merged
WenMeng-NOAA merged 9 commits into
NOAA-EMC:developfrom
BenjaminBlake-NOAA:feature/vegminmax
Oct 22, 2026
Merged

WenMeng-NOAA merged 9 commits into
NOAA-EMC:developfrom
BenjaminBlake-NOAA:feature/vegminmax

Conversation

@BenjaminBlake-NOAA

Copy link
Copy Markdown
Collaborator

Resolves issue #1625

The annual min/max vegetation fractions fields in the RRFS f00 2DFLD GRIB2 files are 0 everywhere. That is because the corresponding variables shdmin and shdmax were not being read in from the RRFS model history files. This PR updates INITPOST_NETCDF.f to read in shdmin and shdmax for RRFS. I also fixed a couple of typos that I found in nearby comments.

There are no baseline changes to the UPP RTs since this only affects the RRFS output at forecast hour 0. I ran a standalone RRFS test using f00 model output and my run directory is here on Cactus:

/lfs/h2/emc/vpppg/noscrub/Benjamin.Blake/upp-pr1626-vegminmax/rrfs_2026102010

These changes will be included in a future RRFSv1.1 update. Tagging @AndrewBenjamin-NOAA and @MatthewPyle-NOAA for awareness.

@BenjaminBlake-NOAA BenjaminBlake-NOAA added bug Something isn't working No Baseline Change No baseline of the UPP regression tests are made. RRFS labels Oct 20, 2026
@WenMeng-NOAA WenMeng-NOAA linked an issue Oct 20, 2026 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Oct 21, 2026
@WenMeng-NOAA

Copy link
Copy Markdown
Collaborator

/lfs/h2/emc/vpppg/noscrub/Benjamin.Blake/upp-pr1626-vegminmax/rrfs_2026102010

@BenjaminBlake-NOAA Your UPP standalone test results look good to me. Both fields VEGMIN and VEGMAX are generated with non-missing values in the 2DFLD dataset.

83:478220907:ndata=14452641:undef=2178132:mean=2.28385:min=0:max=89.5:cos_wt_mean=2.75051
84:482477994:ndata=14452641:undef=2178132:mean=16.349:min=0:max=100:cos_wt_mean=16.2125

@WenMeng-NOAA

WenMeng-NOAA commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

@gspetro-NOAA This PR is ready for the UPP RTs on RDHPCS. There should be no baseline changes expected.

@BenjaminBlake-NOAA

Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA This PR is ready for the UPP RTs on RDHPCS. There should be baseline changes expected.

@WenMeng-NOAA Thanks for running the RTs on WCOSS2! Since this change only affects the RRFS output at forecast hour 0, there are actually no baseline changes expected.

@WenMeng-NOAA

Copy link
Copy Markdown
Collaborator

@gspetro-NOAA This PR is ready for the UPP RTs on RDHPCS. There should be baseline changes expected.

@WenMeng-NOAA Thanks for running the RTs on WCOSS2! Since this change only affects the RRFS output at forecast hour 0, there are actually no baseline changes expected.

@BenjaminBlake-NOAA Thanks for catching typo.

@gspetro-NOAA gspetro-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed without baseline changes on Ursa (both compilers), Hercules, and Orion.

@WenMeng-NOAA

Copy link
Copy Markdown
Collaborator

This PR is ready for merging.

@WenMeng-NOAA
WenMeng-NOAA merged commit 1ee2aac into NOAA-EMC:develop Oct 22, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working No Baseline Change No baseline of the UPP regression tests are made. Ready for commit queue Ready for Review This PR is ready for code review. RRFS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VEGMAX and VEGMIN fields are 0 in RRFS

3 participants