Skip to content

Add annual min/max vegetation fraction to RRFS #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WenMeng-NOAA merged 9 commits into from
Oct 22, 2026
Merged

Add annual min/max vegetation fraction to RRFS #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f1dfa3c
Add annual min/max vegetation fraction to RRFS
Oct 20, 2026
4cf7a02
Merge branch 'develop' into feature/vegminmax
BenjaminBlake-NOAA Oct 21, 2026
1e6284b
Merge branch 'develop' into feature/vegminmax
BenjaminBlake-NOAA Oct 21, 2026
37b464b
Add RT log for WCOSS2
WenMeng-NOAA Oct 21, 2026
8547c2d
ursa intel rt log - pass
gspetro-NOAA Oct 21, 2026
89d274f
ursa intelllvm rt log - pass
gspetro-NOAA Oct 21, 2026
547551b
Merge branch 'feature/vegminmax' of https://github.com/BenjaminBlake-…
gspetro-NOAA Oct 21, 2026
8f26b8a
hercule rt log - pass
gspetro-NOAA Oct 21, 2026
ef87e7d
orion rt log - pass
gspetro-NOAA Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions sorc/ncep_post.fd/INITPOST_NETCDF.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
!> 2025-10-07 | Chris Hill | Add capability to calculate and store cosine of solar zenith angle.
!> 2026-03-09 | Eric James | Add reading in of total dust emissions.
!> 2026-10-02 | Wen Meng | Replace sm with landfrac to mask all land grids for sice
!> 2026-10-20 | Ben Blake | Add annual min/max vegetation fraction
!>
!> @author Hui-Ya Chuang @date 2016-03-04
!----------------------------------------------------------------------
Expand Down Expand Up @@ -120,7 +121,7 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
dustcb,bccb,occb,sulfcb,sscb,dustallcb,ssallcb,dustpm,sspm,pp25cb,pp10cb,no3cb,nh4cb,&
pwat, hwp, aqm_aod550, ltg1_max,ltg2_max,ltg3_max, hail_maxhailcast, &
smoke_ave, dust_ave, coarsepm_ave, wspd10umax, wspd10vmax, f10m, &
mean_frp, emdust
mean_frp, emdust, shdmin, shdmax
use soil, only: sldpth, sllevel, sh2o, smc, stc
use masks, only: lmv, lmh, htm, vtm, gdlat, gdlon, dx, dy, hbm2, sm, sice
use physcons_post, only: grav => con_g, fv => con_fvirt, rgas => con_rd, &
Expand Down Expand Up @@ -2313,8 +2314,18 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
enddo
enddo
! if(debugprint)print*,'sample ',VarName,' = ',vegfrc(isa,jsa)

! GFS doesn not yet output soil layer thickness, assign SLDPTH to be the same as nam

! annual minimum vegetation fraction
VarName='shdmin'
call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,shdmin)

! annual maximum vegetation fraction
VarName='shdmax'
call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,shdmax)

! GFS does not yet output soil layer thickness, assign SLDPTH to be the same as nam

SLDPTH(1) = 0.10
SLDPTH(2) = 0.3
Expand All @@ -2338,9 +2349,9 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
END IF

Status=nf90_inq_varid(ncid2d,'zsoil',varid)
if(Status/=0)then !read soil avriables in 2D
if(Status/=0)then !read soil variables in 2D

! liquid volumetric soil mpisture in fraction using nemsio
! liquid volumetric soil moisture in fraction using nemsio
VarName='soill1'
call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,sh2o(ista_2l,jsta_2l,1))
Expand Down
116 changes: 52 additions & 64 deletions tests/logs/rt.log.HERCULES_intel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,78 +1,66 @@
===== Start of UPP Regression Testing Log =====
UPP Hash Tested:
e8b1cedd61ee84ff6d8374880c532b8db4a05401
37b464b3143377a54a213b43f47ee611db2d4a9f

Submodule hashes:
-68953f566b4d728b9ecf9a352c56e2aaeec6d8ec sorc/libIFI.fd
-8fdeb7a816bab893f670e7f592e98713ff613c8e sorc/ncep_post.fd/post_gtg.fd

Run directory: /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES
Run directory: /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1626/ci/rundir/upp-HERCULES
Baseline directory: /work/noaa/epic/role-epic/hercules/UPP

Total runtime: 00h:31m:52s
Test Date: 20261020 12:22:36
Total runtime: 00h:11m:41s
Test Date: 20261021 13:28:38
Summary Results:

10/20 16:54:02Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
10/20 16:54:03Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.pres.f084.grib2 as the develop branch
10/20 16:54:03Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.sfc.f084.grib2 as the develop branch
10/20 16:54:13Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
10/20 16:54:14Z -sfs test: your new post executable did not generate bit-identical sfs.t00z.master.grb2f060 as the develop branch
10/20 16:54:30Z -hafs test: your new post executable generates bit-identical HURPRS42.tm00 as the develop branch
10/20 16:54:35Z -mpas test: your new post executable generates bit-identical POSTNAT06.tm00 as the develop branch
10/20 16:54:36Z -mpas test: your new post executable generates bit-identical POSTPRS06.tm00 as the develop branch
10/20 16:54:46Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
10/20 16:54:51Z -mpas test: your new post executable did not generate bit-identical POSTTWO06.tm00 as the develop branch
10/20 16:55:00Z -gefsv13 test: your new post executable did not generate bit-identical gefs.t00z.master.grb2f009 as the develop branch
10/20 16:55:01Z -rap test: your new post executable did not generate bit-identical WRFPRS.GrbF06 as the develop branch
10/20 16:55:01Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
10/20 16:55:02Z -3drtma test: your new post executable did not generate bit-identical WRFTWO.GrbF00 as the develop branch
10/20 16:55:04Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
10/20 16:55:18Z -nmmb test: your new post executable did not generate bit-identical BGDAWP03.tm00.Grib2 as the develop branch
10/20 16:55:32Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
10/20 16:55:35Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
10/20 16:55:44Z -nmmb test: your new post executable did not generate bit-identical BGRD3D03.tm00.Grib2 as the develop branch
10/20 16:55:45Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
10/20 16:55:49Z -mpas_hfip test: your new post executable did not generate bit-identical 2DFLD.GrbF48 as the develop branch
10/20 16:56:00Z -hrrr test: your new post executable did not generate bit-identical WRFTWO.GrbF10 as the develop branch
10/20 16:56:04Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
10/20 16:56:06Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
10/20 17:01:00Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
10/20 17:01:01Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
10/20 17:02:57Z -rrfs test: your new post executable generates bit-identical PRSLEV36.tm00 as the develop branch
10/20 17:05:33Z -gfs test: your new post executable did not generate bit-identical gfs.t00z.master.f012.grib2 as the develop branch
10/20 17:05:34Z -gfs test: your new post executable generates bit-identical gfs.t00z.sflux.f012.grib2 as the develop branch
10/20 17:05:35Z -gfs test: your new post executable generates bit-identical gfs.t00z.master-goes.f012.grib2 as the develop branch
10/20 17:19:22Z -rrfs test: your new post executable did not generate bit-identical NATLEV36.tm00 as the develop branch
10/20 17:22:21Z -rrfs test: your new post executable did not generate bit-identical 2DFLD36.tm00 as the develop branch
10/20 16:54:17Z -Runtime: sfs_test 00:00:22 -- baseline 00:01:20
10/20 16:54:17Z -Runtime: aqm_test 00:00:10 -- baseline 00:00:30
10/20 16:54:17Z -Runtime: aigfs_test 00:00:11 -- baseline 00:00:30
10/20 16:54:17Z -Runtime: gefsv12_test 00:00:21 -- baseline 00:01:00
10/20 16:55:03Z -Runtime: gefsv13_test 00:01:09 -- baseline 00:02:00
10/20 16:55:48Z -Runtime: nmmb_test 00:01:53 -- baseline 00:03:00
10/20 16:55:49Z -Runtime: rap_test 00:01:09 -- baseline 00:02:00
10/20 16:56:19Z -Runtime: hrrr_test 00:02:14 -- baseline 00:06:00
10/20 16:56:19Z -Runtime: hafs_test 00:00:38 -- baseline 00:01:00
10/20 16:56:19Z -Runtime: 3drtma_test 00:01:12 -- baseline 00:03:00
10/20 16:56:19Z -Runtime: mpas_test 00:00:59 -- baseline 00:02:30
10/20 16:56:19Z -Runtime: mpas_hfip_test 00:02:11 -- baseline 00:05:00
10/20 17:01:04Z -Runtime: gcafs_test 00:02:50 -- baseline 00:02:30
10/20 17:22:36Z -Runtime: rrfs_test 00:28:24 -- baseline 00:12:00
10/20 17:22:36Z -Runtime: gfs_test 00:11:33 -- baseline 00:25:00
10/21 18:19:15Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.pres.f084.grib2 as the develop branch
10/21 18:19:15Z -aigfs test: your new post executable generates bit-identical aigfs.t18z.sfc.f084.grib2 as the develop branch
10/21 18:19:16Z -aqm test: your new post executable generates bit-identical CMAQ08.tm00 as the develop branch
10/21 18:19:23Z -gefsv12 test: your new post executable generates bit-identical geaer.t00z.master.grb2f060 as the develop branch
10/21 18:19:24Z -sfs test: your new post executable generates bit-identical sfs.t00z.master.grb2f060 as the develop branch
10/21 18:19:43Z -hafs test: your new post executable generates bit-identical HURPRS42.tm00 as the develop branch
10/21 18:19:50Z -gefsv13 test: your new post executable generates bit-identical gefs.t00z.master.grb2f009 as the develop branch
10/21 18:19:51Z -mpas test: your new post executable generates bit-identical POSTNAT06.tm00 as the develop branch
10/21 18:19:52Z -mpas test: your new post executable generates bit-identical POSTPRS06.tm00 as the develop branch
10/21 18:19:52Z -mpas test: your new post executable generates bit-identical POSTTWO06.tm00 as the develop branch
10/21 18:19:54Z -3drtma test: your new post executable generates bit-identical WRFNAT.GrbF00 as the develop branch
10/21 18:19:55Z -3drtma test: your new post executable generates bit-identical WRFTWO.GrbF00 as the develop branch
10/21 18:19:55Z -3drtma test: your new post executable generates bit-identical WRFPRS.GrbF00 as the develop branch
10/21 18:20:01Z -rap test: your new post executable generates bit-identical WRFPRS.GrbF06 as the develop branch
10/21 18:20:01Z -rap test: your new post executable generates bit-identical WRFNAT.GrbF06 as the develop branch
10/21 18:20:15Z -nmmb test: your new post executable generates bit-identical BGDAWP03.tm00.Grib2 as the develop branch
10/21 18:20:16Z -nmmb test: your new post executable generates bit-identical BGRD3D03.tm00.Grib2 as the develop branch
10/21 18:20:16Z -nmmb test: your new post executable generates bit-identical BGRDSF03.tm00.Grib2 as the develop branch
10/21 18:20:57Z -mpas_hfip test: your new post executable generates bit-identical NATLEV.GrbF48 as the develop branch
10/21 18:20:58Z -mpas_hfip test: your new post executable generates bit-identical PRSLEV.GrbF48 as the develop branch
10/21 18:20:59Z -mpas_hfip test: your new post executable generates bit-identical 2DFLD.GrbF48 as the develop branch
10/21 18:20:59Z -hrrr test: your new post executable generates bit-identical WRFTWO.GrbF10 as the develop branch
10/21 18:20:59Z -hrrr test: your new post executable generates bit-identical WRFPRS.GrbF10 as the develop branch
10/21 18:21:00Z -hrrr test: your new post executable generates bit-identical WRFNAT.GrbF10 as the develop branch
10/21 18:21:38Z -gcafs test: your new post executable generates bit-identical GFSPRS.GrbF60 as the develop branch
10/21 18:21:38Z -gcafs test: your new post executable generates bit-identical GFSFLX.GrbF60 as the develop branch
10/21 18:28:04Z -rrfs test: your new post executable generates bit-identical PRSLEV36.tm00 as the develop branch
10/21 18:28:29Z -rrfs test: your new post executable generates bit-identical NATLEV36.tm00 as the develop branch
10/21 18:28:30Z -gfs test: your new post executable generates bit-identical gfs.t00z.master.f012.grib2 as the develop branch
10/21 18:28:32Z -rrfs test: your new post executable generates bit-identical 2DFLD36.tm00 as the develop branch
10/21 18:28:32Z -gfs test: your new post executable generates bit-identical gfs.t00z.sflux.f012.grib2 as the develop branch
10/21 18:28:32Z -gfs test: your new post executable generates bit-identical gfs.t00z.master-goes.f012.grib2 as the develop branch
10/21 18:19:37Z -Runtime: sfs_test 00:00:16 -- baseline 00:01:20
10/21 18:19:37Z -Runtime: aqm_test 00:00:08 -- baseline 00:00:30
10/21 18:19:37Z -Runtime: aigfs_test 00:00:07 -- baseline 00:00:30
10/21 18:19:37Z -Runtime: gefsv12_test 00:00:15 -- baseline 00:01:00
10/21 18:19:52Z -Runtime: gefsv13_test 00:00:42 -- baseline 00:02:00
10/21 18:20:23Z -Runtime: nmmb_test 00:01:08 -- baseline 00:03:00
10/21 18:20:23Z -Runtime: rap_test 00:00:54 -- baseline 00:02:00
10/21 18:21:08Z -Runtime: hrrr_test 00:01:52 -- baseline 00:06:00
10/21 18:21:08Z -Runtime: hafs_test 00:00:35 -- baseline 00:01:00
10/21 18:21:08Z -Runtime: 3drtma_test 00:00:47 -- baseline 00:03:00
10/21 18:21:08Z -Runtime: mpas_test 00:00:44 -- baseline 00:02:30
10/21 18:21:08Z -Runtime: mpas_hfip_test 00:01:52 -- baseline 00:05:00
10/21 18:21:53Z -Runtime: gcafs_test 00:02:30 -- baseline 00:02:30
10/21 18:28:38Z -Runtime: rrfs_test 00:09:24 -- baseline 00:12:00
10/21 18:28:38Z -Runtime: gfs_test 00:09:24 -- baseline 00:25:00
Check tests:
['sfs', 'aqm', 'aigfs', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
There are changes in results for case mpas_hfip in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/mpas_hfip_2024100700/2DFLD.GrbF48
There are changes in results for case mpas in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/mpas_2024052700/POSTTWO06.tm00
There are changes in results for case 3drtma in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/3drtma_2025091010/WRFTWO.GrbF00
There are changes in results for case gefsv13 in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/gefsv13_2023080300/gefs.t00z.master.grb2f009
There are changes in results for case hrrr in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/hrrr_2025063004/WRFTWO.GrbF10
There are changes in results for case sfs in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/sfs_2017050100/sfs.t00z.master.grb2f060
There are changes in results for case nmmb in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/nmmb_2014120818/BGDAWP03.tm00.Grib2
There are changes in results for case nmmb in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/nmmb_2014120818/BGRD3D03.tm00.Grib2
There are changes in results for case rap in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/rap_2025070115/WRFPRS.GrbF06
There are changes in results for case gfs in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/gfs_2026081800/gfs.t00z.master.f012.grib2
There are changes in results for case rrfs in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/rrfs_2026032512/NATLEV36.tm00
There are changes in results for case rrfs in /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES/rrfs_2026032512/2DFLD36.tm00
Refer to .diff files in rundir: /work2/noaa/epic/gpetro/hercules/RTs/upp-rts/1608/ci/rundir/upp-HERCULES for details on differences in results for each case.
No changes in test results detected.
===== End of UPP Regression Testing Log =====
Loading
Loading