Repository navigation
Run main from the Garnatxa launcher, pulled on every launch - #12
Merged
Merged
Conversation
conf/garnatxa.sbatch asked for feat/gene-conversion, a branch deleted once it was merged, which Nextflow can no longer pull. It now runs main. A branch also needs -latest. Nextflow keeps a clone of the project under ~/.nextflow/assets and, without it, runs the copy it cloned the first time: a fix merged since then does not arrive, and a relaunch repeats the failure with the code that caused it. The comment above REVISION said the report's provenance footer records the revision. It records the container, the references and the gene-conversion settings, so it now points at the driver log, where Nextflow prints the commit it ran. Two small fixes in the same file: the log's Nextflow line printed the word "build" instead of the version, and the usage message named SLURM's spooled copy of the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
conf/garnatxa.sbatchasked forfeat/gene-conversion, a branch deleted once it was merged, so Nextflow can no longer pull it. The template now runsmain.A branch also needs
-latest. Nextflow keeps a clone of the project under~/.nextflow/assetsand, without it, runs the copy it cloned the first time, so a fix merged since does not arrive. The template now passes it.Defaults and outputs
REVISIONdefaults tomaininstead offeat/gene-conversion. To pin a run, set it to a release tag or a commit. Nextflow prints the commit it ran at the top of the driver log.REVISIONsaid the report's provenance footer records the revision. The footer records the container, the references and the gene-conversion settings, so the comment now points at the driver log.nextflow -versionprintsversion <X> build <N>. The usage message named SLURM's spooled copy of the script instead of the template.How it was verified
A dry run with stand-ins for
moduleandnextflowsubmitsnextflow run PathoGenOmics-Lab/BAMpiro -r main -latest -profile garnatxa -resume -ansi-log false --tsv samples.tsv --outdir results. The version line reads the number from a-versionbanner, and a missing samplesheet exits 2 with the template's name in the usage line. The template itself has not been submitted on Garnatxa from this branch.Checklist
tests/run_tests.shpasses locally (the lint leg; no Python or Nextflow code changed)ruff check .is clean, and I did not restyle code the change does not touchmodules/has astub:block (not applicable: no new process)tests/data/was not edited by hand (fixtures come frommake_test_data.py)CHANGELOG.mdentry and, where relevant, a docs update