Skip to content

refactor(plugins): delete dead plugin manager code - #3482

Merged
datlechin merged 1 commit into
mainfrom
refactor/plugin-manager-dead-code
Oct 17, 2026
Merged

datlechin merged 1 commit into
mainfrom
refactor/plugin-manager-dead-code

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

Cleanup sweep, S1: plugin manager code with no caller or no reader, and a fake install progress.

Change

  • Delete what nothing calls or reads: validateDependencies, validateConnectionFields, validateDialectDescriptor, loadPendingPluginsAsync, outdatedReconcileReason, existingPluginLoaded, performRegistryInstall, the second markStaged, the permission API on PluginNotificationService, the category and tagline fallback table, and the unreachable re-validate and isOutdated paths.
  • Plugin downloads report the task's own progress instead of a fixed 0, 0.5, 1. With no Content-Length the bar stays indeterminate.
  • validateBundleVersions replaces validateStagedABI before atomicReplace; the checksum streams the file; no manual .bak removal.
  • Delete the PluginKit history comment. The two version constants stay.

Verified

PluginInstallerHelpersTests: the validateStagedABI cases now run against validateBundleVersions, plus two download progress cases.

Not in this PR

  • PluginActionResult stays: InstalledPluginsView still reads it.

@datlechin
datlechin merged commit d5aae7f into main Oct 17, 2026
7 checks passed
@datlechin
datlechin deleted the refactor/plugin-manager-dead-code branch October 17, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant