Conversation
ahoereth
marked this pull request as ready for review
August 31, 2026 07:08
Author
|
Additional context: Isaac Sim already supports this contract for articulations containing additional joints. It resolves only the configured joints with This allows passive or otherwise unconfigured joints to remain in the articulation without appearing in Holosoma's public DOF tensors. MuJoCo currently differs in two ways:
As a result, valid MuJoCo models containing linkage, pulley, or other passive joints can produce public state tensors with the wrong shape and ordering. This PR brings MuJoCo closer to the existing Isaac Sim behavior. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
MuJoCo models can contain passive joints interleaved with actuated joints. Holosoma currently treats every named non-free robot joint as a public DOF and represents the resulting state using contiguous slices. This can include passive joints in the public state tensors and cause their shape and ordering to differ from
robot_config.dof_names.This aligns MuJoCo’s public DOF selection with Isaac Sim, which resolves and indexes only the joints listed in
robot_config.dof_names.This change:
robot_config.dof_names, excluding passive model joints;actuated → passive → actuatedMJCF regression covering passive-joint exclusion and state preservation;By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.