Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MuJoCo 3.12 bundles pybind11 3.1, which changed equality between MuJoCo's pybind enum values and the NumPy integer scalars exposed by model arrays. In 3.12 the comparison is asymmetric:
np.int32 == mujoco_enumremains true, butmujoco_enum == np.int32is false. Python tuple membership compares from the tuple element's side, so the scalar-joint check in_build_transform_qdot_to_qvel_fast()no longer recognizes hinge or slide joints.As a result, the transform omits every scalar-joint
qdot -> qvelidentity entry. All corresponding columns in the retargeter's position and orientation Jacobians become zero, so optimization can move the floating base but cannot articulate the robot.Minimal reproduction with MuJoCo 3.12:
This change normalizes joint types and enum constants to plain integers before comparing them. It applies the same normalization to free, ball, hinge, and slide checks so the transform does not depend on operand direction or pybind enum equality semantics.
Validation: