Repository navigation
chore(test): DB-ESDK cross-language test-server language adapters - #2374
Merged
Merged
Conversation
hanabanaka
force-pushed
the
huaye/dbesdk-test-server
branch
2 times, most recently
from
September 15, 2026 18:54
90accbc to
ebd17cc
Compare
Adds the java-v3, rust-v1, and net-v4 DB-ESDK Test Server language adapters: the item-encryptor and transforms wire operations over rpcv2Cbor, the server-wrapper tests ported to the DB-ESDK item API, a declarative branchKeyIdSupplier wired into the hierarchical keyring, the raw-RSA feature declaration, and the java-v3 known-bug declarations for the deep-nesting request-validator overflow and the missing 4096-char expression-length guard in the pinned published 3.8.1.
hanabanaka
force-pushed
the
huaye/dbesdk-test-server
branch
from
September 15, 2026 19:55
ebd17cc to
ae88818
Compare
lucasmcdonald3
left a comment
lucasmcdonald3
left a comment
Contributor
There was a problem hiding this comment.
Let's also run the test server CI from this repo
…sable workflow Add a thin caller that uses aws-crypto-tools-commons' reusable dbesdk-test-server.yml (workflow_call) and passes this repo's commit as dbe_ref, so a change to the language adapters here triggers the cross-language run against this PR's servers. The full CI definition is not re-declared. Requires the commons reusable workflow on the referenced ref and the KMS OIDC role trusting this repo.
…ommons harness via PAT
…v3 server comments
lucasmcdonald3
previously approved these changes
Sep 18, 2026
kessplas
requested changes
Sep 18, 2026
| @@ -0,0 +1 @@ | |||
| a82094c6ad32f64db21d6231e74231d55e61016c No newline at end of file | |||
Contributor
Author
There was a problem hiding this comment.
Removed and added to gitignore
| // a GenericServerError, per the operation wrapper. | ||
| status = StatusCodes.Status400BadRequest; | ||
| payload = EncodeError(ServerException.Generic( | ||
| $"malformed rpcv2Cbor request: {unexpected.Message}")); |
Contributor
There was a problem hiding this comment.
malformed rpcv2Cbor request is only one possible failure,
this error message should be more generic,
since this is a catch-all block
…lize the net catch-all error message Untrack test-server/net-v4-server/.dbesdk-build-stamp (a per-server build marker) and add a .gitignore rule so it is not committed again. Make the net server's catch-all handler report a generic 'unexpected server error' instead of naming malformed rpcv2Cbor, since it catches any framework failure.
kessplas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB-ESDK cross-language test-server language adapters (java-v3, rust-v1, net-v4).
Companion to aws-crypto-tools-commons#16 (the test server, orchestrator, and test cases).