Repository navigation
ax-server, e2e: enable workspace pre-warming by default and add shared custom-image E2E - #651
Merged
Merged
Conversation
yongruilin
reviewed
Nov 19, 2026
… and fix E2E template
mayawang
approved these changes
Nov 19, 2026
mayawang
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, nice coverage, thanks Simran! Heads up this collides with #647: once pre-warm is always on, a Workspace with setup needs profile.image, and every Task needs one too. Your new E2E workspace and task 1 have neither, and neither does hack/hero-demo/workspace.yaml. Probably easiest to let #647 land first, then rebase and add profile.image to those three. @rakyll does that order work for you?
Collaborator
YoyinZyc
added a commit
that referenced
this pull request
Nov 20, 2026
Workspace pre-warming is on by default since #651, so Step 2 of the hero demo no longer has to be a stub. - hack/hero-demo: workspace.yaml gets a spec.profile that matches task-starter.yaml, so the starter task starts from the workspace's snapshot. run.sh waits for the apply, which pre-warms, and passes when the workspace reports SnapshotReady. STARTER_IMAGE now applies to both manifests. - ax apply: CreateWorkspace returns only once the workspace is pre-warmed, so it gets lifecycleRPCTimeout (5m) instead of the 30s shared by the rest of the apply. - ax-server: drop firstUnimplementedWorkspaceField. It rejected spec.profile and spec.setup.gateway until the SetupCoordinator was wired, which it now is whenever the runner server is on. - docs/manifests.md: spec.profile and spec.setup.gateway are available; add a section on how pre-warming works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables workspace snapshot pre-warming by default in
ax-serverand adds end-to-end coverage for workspace pre-warming, explicit suspend/resume, completion, and running a plain custom container image against a shared workspace.Key Changes
cmd/ax-server/main.go: Always wireSetupCoordinator: runnerSrvintoWorkspaceManagerwhen--runner-addris enabled, removing the--enable-prewarm/AX_ENABLE_PREWARMgate.test/e2e/launcher_test.go: AddTestE2E_PrewarmAndCustomImageSharedWorkspacecovering:Workspacewithsetup.files+setup.commandsand verifying it pre-warms toReady.COMPLETEDwithOutcome.Output.AX_E2E_LAUNCHER_IMAGE, runner mounted read-only) on the same workspace throughQUEUED → WORKING → SUSPENDED → WORKING → COMPLETED, preserving/workspaceacross explicit suspend/resume.Testing
go test ./cmd/ax-server/...go test -c -o /dev/null ./test/e2e/...