Repository navigation
feat: Axes honors a color override from spatialgeometry - #168
Merged
Merged
Conversation
loadAxes() ignored part.color. Now a non-null color colors all three axes, in both AxesHelper (line) and per-arrow styles; null keeps the conventional X red / Y green / Z blue. Adds Node tests for both styles and both shaft types. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1.4.2 is the first spatialgeometry that sends color=None for an Axes with no color; an older release always sends a grey color, which the new Axes override would apply to every Axes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to jhavl/spatialgeometry#55.
loadAxes()ignoredpart.color, soAxes(1, color="black")still rendered red/green/blue.colornull (none given): X red / Y green / Z blue, as before.colorset: all three axes use it, in both the plain-line style (AxesHelper.setColors()) andarrows=True(per-arrow color, tube and line shafts).loadAxesis exported so it can be tested under Node; 4 new tests inshapes.test.js. All 27 JS tests and 120 Python tests pass.Merge order: spatialgeometry#55 first, or both together. An older spatialgeometry always sends a (grey) color, which this change would apply to every Axes.
🤖 Generated with Claude Code