Skip to content

LCORE-4550: various pytest parametrize fixes - #2870

Merged
tisnik merged 3 commits into
lightspeed-core:mainfrom
tisnik:lcore-4550-various-pytest-parametrize-fixes
Oct 8, 2026
Merged

tisnik merged 3 commits into
lightspeed-core:mainfrom
tisnik:lcore-4550-various-pytest-parametrize-fixes

Conversation

@tisnik

@tisnik tisnik commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

LCORE-4550: various pytest parametrize fixes

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-4550

Summary by CodeRabbit

  • Tests
    • Clarified parameter-name declarations in authentication tests; test cases and behavior are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lightspeed-core/lightspeed-stack/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 192e7b49-21b2-4e12-9c1b-2111156232ff
📥 Commits

Reviewing files that changed from the base of the PR and between 5737342 and c3976a8.

📒 Files selected for processing (1)
  • tests/unit/authentication/test_rh_identity.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (30)
  • GitHub Check: E2E: library / ci / other
  • GitHub Check: E2E: library / ci / authorized
  • GitHub Check: E2E: server / ci / authorized
  • GitHub Check: E2E: server / ci / other
  • GitHub Check: E2E: server / ci / mcp
  • GitHub Check: E2E: server / ci / shields
  • GitHub Check: E2E: library / ci / mcp
  • GitHub Check: E2E: library / ci / default
  • GitHub Check: E2E: library / ci / shields
  • GitHub Check: E2E: library / ci / skills
  • GitHub Check: E2E: server / ci / skills
  • GitHub Check: E2E: server / ci / rbac
  • GitHub Check: E2E: server / ci / tls
  • GitHub Check: E2E: library / ci / rbac
  • GitHub Check: E2E: server / ci / default
  • GitHub Check: spectral
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: radon
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: ruff
  • GitHub Check: list_outdated_dependencies
  • GitHub Check: build-pr
  • GitHub Check: Pylinter
  • GitHub Check: Pyright
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
🔇 Additional comments (1)
tests/unit/authentication/test_rh_identity.py (1)

219-219: LGTM!

Also applies to: 235-235, 250-250, 298-298


Walkthrough

Four parametrized tests in the RH identity test module now declare argument names as tuples. The test cases and behavior are unchanged.

Changes

Authentication test parametrization

Layer / File(s) Summary
Update parametrization declarations
tests/unit/authentication/test_rh_identity.py
Four parametrized tests now use tuples for their argument-name declarations. Their cases are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to c3976

The four parametrization declarations now use tuples, with no reported change to test cases or behavior. No concrete merge-blocking risk is apparent.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the related issue and the main change: pytest parametrization fixes. It matches the pull request changes and objectives.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed PASSED. The pull request changes only four pytest.mark.parametrize argument-name declarations in tests/unit/authentication/test_rh_identity.py (lines 219, 235, 250, and 298). It adds no loops, API…
Security And Secret Handling ✅ Passed PASSED. The pull request changes only four pytest.mark.parametrize argument declarations in tests/unit/authentication/test_rh_identity.py (lines 190, 207, 224, and 244). It changes comma-separated…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik merged commit 78d9d9f into lightspeed-core:main Oct 8, 2026
43 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant