Skip to content

LCORE-4550: various pytest parametrize fixes #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 3 commits into from
Oct 8, 2026
Merged

LCORE-4550: various pytest parametrize fixes #2870

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f578c81
LCORE-4550: Fixed pytest parametrize parameter
tisnik Oct 8, 2026
d5f96df
LCORE-4551: Fixed pytest parametrize parameter
tisnik Oct 8, 2026
c3976a8
LCORE-4552: Fixed pytest parametrize parameter
tisnik Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/unit/authentication/test_rh_identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def test_get_org_id_missing(self, user_identity_data: dict[str, Any]) -> None:
assert rh_identity.get_org_id() == ""

@pytest.mark.parametrize(
"service,expected",
("service", "expected"),
[
("rhel", True), # Entitled service
("ansible", True), # Entitled service
Expand All @@ -232,7 +232,7 @@ def test_has_entitlement(
assert rh_identity.has_entitlement(service) is expected

@pytest.mark.parametrize(
"services,expected",
("services", "expected"),
[
(["rhel", "ansible"], True), # All entitled
(["rhel", "openshift"], False), # One not entitled
Expand All @@ -247,7 +247,7 @@ def test_has_entitlements(
assert rh_identity.has_entitlements(services) is expected

@pytest.mark.parametrize(
"required_entitlements,should_raise,expected_error",
("required_entitlements", "should_raise", "expected_error"),
[
(["rhel"], False, None), # Single valid
(["rhel", "ansible"], False, None), # Multiple valid
Expand Down Expand Up @@ -295,7 +295,7 @@ def test_validate_entitlements(
rh_identity.validate_entitlements()

@pytest.mark.parametrize(
"missing_field,expected_error",
("missing_field", "expected_error"),
[
({"identity": None}, "Invalid identity data"),
({"identity": {"org_id": "123"}}, "Invalid identity data"),
Expand Down
Loading