Repository navigation
Conversation
flodolo
requested changes
Aug 30, 2026
| pdfjs-print-button-label = Print | ||
| pdfjs-save-button = | ||
| .title = Save | ||
| .aria-label = Save |
Contributor
There was a problem hiding this comment.
This type of change requires a new ID
https://mozilla-l10n.github.io/documentation/localization/making_string_changes.html
Contributor
Author
|
Addressed the localization review: kept pdfjs-save-button unchanged, added the new pdfjs-save-button-with-aria-label ID, and switched the standard viewer button to use it. |
Collaborator
|
Sorry, but setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20473
The standard viewer's save button uses the localized
pdfjs-save-buttonmessage, but that message only exposed a tooltip through.title. Add a localized.aria-labelso screen reader users receive an accessible name.The integration test checks the rendered
#downloadButtonin the viewer and verifies itsaria-label.Tests:
node --check test/integration/viewer_spec.mjs(full PDF.js integration tests require the repository dependencies and browser test setup).