Skip to content

Add an accessible name to the save button #21851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xjtu-ctgg wants to merge 4 commits into from
Closed

Add an accessible name to the save button #21851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
907438f
Add an accessible name to the save button
xjtu-ctgg Aug 30, 2026
c8edb8e
Test the save button accessible name
xjtu-ctgg Aug 30, 2026
2997dca
Use a new localization ID for the save button accessible name
xjtu-ctgg Aug 30, 2026
efd39ba
Use the accessible save button localization ID
xjtu-ctgg Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions l10n/en-US/viewer.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ pdfjs-save-button =
.title = Save
pdfjs-save-button-label = Save

pdfjs-save-button-with-aria-label =
.title = Save
.aria-label = Save

# Used in Firefox for Android as a tooltip for the download button (“download” is a verb).
pdfjs-download-button =
.title = Download
Expand Down
24 changes: 24 additions & 0 deletions test/integration/viewer_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,30 @@ import { PNG } from "pngjs";
const __dirname = import.meta.dirname;

describe("PDF viewer", () => {
describe("Toolbar accessibility", () => {
let pages;

beforeEach(async () => {
pages = await loadAndWait("tracemonkey.pdf", ".textLayer .endOfContent");
});

afterEach(async () => {
await closePages(pages);
});

it("exposes an accessible name for the save button", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
const ariaLabel = await page.$eval(
"#downloadButton",
button => button.getAttribute("aria-label")
);
expect(ariaLabel).withContext(`In ${browserName}`).toEqual("Save");
})
);
});
});

describe("EFOpen attachments", () => {
let pages;

Expand Down
2 changes: 1 addition & 1 deletion web/viewer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@
<span data-l10n-id="pdfjs-print-button-label"></span>
</button>

<button id="downloadButton" class="toolbarButton" type="button" tabindex="0" data-l10n-id="pdfjs-save-button">
<button id="downloadButton" class="toolbarButton" type="button" tabindex="0" data-l10n-id="pdfjs-save-button-with-aria-label">
<span data-l10n-id="pdfjs-save-button-label"></span>
</button>
</div>
Expand Down