Repository navigation
test(types): stop authoring the retired addRecord.mode / formView in two spec-alignment tests - #13312
Merged
objectstack-fleet[bot] merged 2 commits intoOct 21, 2026
Conversation
…gnment tests objectstack retired both keys; the typed values no longer compile against a spec built from objectstack main. enabled and position stay. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
…hing Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
objectstack-fleet
Bot
deleted the
claude/issue-13308-add-record-retired-keys
branch
October 21, 2026 10:21
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13308
Clause-②: no
What
objectstack-ai/objectstack#24970 retired
addRecord.modeandaddRecord.formView(retiredKey()tombstones). Two@object-ui/typestests still authored both keys on typed values, which is what turns objectstack's hourly Spec Shape Gate red (fourTS2322s). Test-only change:packages/types/src/__tests__/p2-spec-exports.test.ts: theAddRecordConfigvalue keepsenabledandpositiononly; the test name "should validate a full AddRecordConfig" now says what it checks ("with enabled and position").packages/types/src/__tests__/p1-spec-alignment.test.ts: theListViewSchema.addRecordvalue keepsenabledandposition; theschema.addRecord?.modeassertion is dropped..changeset/13308-add-record-retired-keys.md: empty frontmatter (releases nothing).check-changeset-presenceasked for it, because files underpackages/types/srccount as that package's source.No source file changes.
.objectstack-shadoes not move. Outside tests, nothing in the tree authors or readsaddRecord.mode/addRecord.formView(git grep). The only other mentions are prose: CHANGELOGs,plugin-listregistration description text, a parity-ledger note string.Evidence (head
562f56cc00)06cab48):pnpm --filter @object-ui/types run type-checkexited 0.main28c9a2cb66(that main already containsfde7456352,merge-base --is-ancestorexit 0): I built and packed@objectstack/specin a separate objectstack worktree, then put it into this worktree's install withscripts/ci/spec-shape-gate.mjs inject, the gate's own wiring (32 consumers re-pointed).type-checkexited 0.2794254099(pre-fix main), andtsc -p tsconfig.test.jsonexited 2 with exactly the gate's four diagnostics,p1-spec-alignment.test.ts(184,9),(185,9)andp2-spec-exports.test.ts(143,9),(144,9):TS2322 Type 'string' is not assignable to type '{ '[REMOVED] Key retired: ...': never; }'. The trap then restored both files withgit checkout HEAD --.git diff HEADcame back empty, and both blob hashes match HEAD.--maxWorkers=1): the two edited files passed 59/59. The three tests that name them (page-node-type-contract,phase2-schemas,related-list-filter-rule-array-10199) passed 51/51. I ran no whole-directory test locally;packages/typesin full is declared to CI.--no-inline-configon the 2 changed.tsfiles gave 0 errors and 0 warnings (2 files per--format json). The repo config has no type-aware linting, so this diff cannot change any untouched file's result.check:spec-floorsexited 1 withno-artifactbecause the workspace was not built. That is NOT MEASURED, not a red.Acceptance notes
mode/formViewretirement and on PR #24778's widenedDroppedFieldsEvent.reason, and neither is registered objectstack#25055's registry entry (objectstack PR #25091, open, not merged when this was written) lists these four diagnostics asknown. Once this lands, that entry matches nothing and is deleted when types: two spec-alignment tests still authoraddRecord.mode/formView, which objectstack PR #24970 retired, so the Spec Shape Gate compiles objectui main red #13308 closes.Generated by Claude Code