Skip to content

test(types): stop authoring the retired addRecord.mode / formView in two spec-alignment tests #13312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 2 commits into from
Oct 21, 2026
Merged

test(types): stop authoring the retired addRecord.mode / formView in two spec-alignment tests #13312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e525fc1
test(types): stop authoring addRecord.mode / formView in two spec-ali…
claude Oct 21, 2026
562f56c
chore(changeset): declare the addRecord test cleanup as releasing not…
claude Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/13308-add-record-retired-keys.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Test-only change to two `@object-ui/types` spec-alignment tests: they stop authoring `addRecord.mode` / `addRecord.formView`, which `@objectstack/spec` retired. No published behaviour changes.
3 changes: 0 additions & 3 deletions packages/types/src/__tests__/p1-spec-alignment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,9 @@ describe('P1.1 ListView Spec Alignment', () => {
addRecord: {
enabled: true,
position: 'top',
mode: 'inline',
formView: 'quick_create',
},
};
expect(schema.addRecord?.enabled).toBe(true);
expect(schema.addRecord?.mode).toBe('inline');
});

it('should accept ObjectGridSchema with spec-aligned conditionalFormatting and emptyState', () => {
Expand Down
4 changes: 1 addition & 3 deletions packages/types/src/__tests__/p2-spec-exports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,10 @@ describe('P2.4 Spec Protocol Type Re-exports — View Configuration', () => {
expect(result.success).toBe(true);
});

it('should validate a full AddRecordConfig', () => {
it('should validate an AddRecordConfig with enabled and position', () => {
const config: AddRecordConfig = {
enabled: true,
position: 'top',
mode: 'inline',
formView: 'new-contact-form',
};
const result = AddRecordConfigZod.safeParse(config);
expect(result.success).toBe(true);
Expand Down
Loading