Repository navigation
[GPU] remove defensive handle about oc-broadcast - #38934
Merged
clee30 merged 3 commits intoOct 22, 2026
Merged
Conversation
clee30
reviewed
Oct 17, 2026
sungeunk
approved these changes
Oct 22, 2026
sungeunk
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Fixed perf issue on B70
clee30
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
[1, G]/[G, 1]) in the oneDNN FullyConnected implementation:get_grouped_mask()clears the OC bit from the grouped scale/zp mask whenever the OC dim of the scale/zp is 1.[1, 2048]with a transposed scale[1, 16](group size 128) lost the OC bit; for a 2D FC that leaves mask = 1, K only. oneDNN's gemm doesn't support that mask, so oneDNN falls back to the referenceocl:ref:anymatmul, a performance regression for this dynamic-shape FC.[N, G, 1], whichConvertFullyConnectedToFullyConnectedCompressedreshapes to[N, G], so the scale/zp OC dim always matches the weights' N.get_grouped_mask()and restores the fullgroupedmask for grouped scale/zp in bothcreate()andload(), i.e. the behavior before [GPU] Refactor for FC Compressed #38697. It also removes thecompressed_int8_broadcast_scale_zpunit tests, which covered only the removed path.Tickets:
AI Assistance:
gemm_tvsref_t), analyze the scale/zp mask computed byget_grouped_mask(), check where scale/zp shapes come from in the compression pipeline, and draft this description.