Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Afloat16
marked this pull request as ready for review
November 3, 2026 13:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RangeBearingSensor.Hpdocuments accepting either landmark coordinates or a map index. The index path callsLandmarkMap.landmark, which does not exist, so that documented use raisesAttributeError.Change
Resolve the landmark through the map's indexing API, as
handHxalready do. The numerical Jacobian formula is unchanged.The regression covers Python and NumPy integer indices, compares the result with coordinate-based lookup, and independently checks it against central differences of the observation function.
Validation
AttributeErroron the original source.PYTHONPATH=src python -m pytest tests/test_sensor_observation_shape.py tests/test_vehicle_estimators.py -q: 64 passed, 30 subtests passed.git diff --checkpassed.