Repository navigation
Conversation
Afloat16
marked this pull request as ready for review
November 3, 2026 13:56
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PRM roadmap construction rejection-samples coordinates until it finds an unoccupied point. When the occupancy grid has no free cells, that loop never terminates. This can also occur after obstacle inflation removes the last free cell.
Change
Before sampling a nonempty roadmap, check whether the effective occupancy grid contains any free cells and raise
NoPathErrorif it does not. Document the error onplan. Empty roadmap requests retain their existing behaviour.The regression covers both an initially full grid and a grid made full by inflation, plus a free-space control that builds a real roadmap. The impossible cases use the project's timeout plugin to detect the former infinite loop.
Validation
PYTHONPATH=src python -m pytest tests/test_prm_free_space.py tests/test_mobile_planners_a.py tests/test_mobile_performance.py -k 'PRM or prm or free_cells' -q: 14 passed, 22 deselected.git diff --checkpassed.