Skip to content

fix(ro): add start years for Ziua Unirii and Sfântul Andrei - #160

Open
vicuts wants to merge 1 commit into
rickar:masterfrom
vicuts:fix/ro-holiday-start-years
Open

vicuts wants to merge 1 commit into
rickar:masterfrom
vicuts:fix/ro-holiday-start-years

Conversation

@vicuts

@vicuts vicuts commented Oct 10, 2026

Copy link
Copy Markdown

ZiuaUniriiPrincipatelorRomane (24 January) and SfantulAndrei (30 November) have no StartYear, so Calc returns them for every year. Both were added to the list of public holidays in art. 139(1) of the Labour Code (Law 53/2003) later:

This adds StartYear: 2012 and StartYear: 2017, the same way the file already handles Boboteaza and Sfântul Ion (2024), Vinerea Mare (2018) and Ziua Copilului (2017). python-holidays uses the same start years for both days (romania.py), and the same start years are proposed for date-holidays in commenthol/date-holidays#674.

master this PR
ZiuaUniriiPrincipatelorRomane.Calc(2016) 2016-01-24 zero time (no holiday)
ZiuaUniriiPrincipatelorRomane.Calc(2017) 2017-01-24 2017-01-24
SfantulAndrei.Calc(2011) 2011-11-30 zero time (no holiday)
SfantulAndrei.Calc(2012) 2012-11-30 2012-11-30

Tests: the 2015 and 2016 rows for Ziua Unirii now expect time.Time{}, and Sfântul Andrei gets a 2011 row (no holiday) and a 2012 row (first year). The 2015, 2016 and 2011 rows fail on master. gofmt -s -l, go vet ./ro/... and go test -cover ./... pass on Go 1.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant