Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZiuaUniriiPrincipatelorRomane(24 January) andSfantulAndrei(30 November) have noStartYear, soCalcreturns them for every year. Both were added to the list of public holidays in art. 139(1) of the Labour Code (Law 53/2003) later:This adds
StartYear: 2012andStartYear: 2017, the same way the file already handles Boboteaza and Sfântul Ion (2024), Vinerea Mare (2018) and Ziua Copilului (2017). python-holidays uses the same start years for both days (romania.py), and the same start years are proposed for date-holidays in commenthol/date-holidays#674.ZiuaUniriiPrincipatelorRomane.Calc(2016)ZiuaUniriiPrincipatelorRomane.Calc(2017)SfantulAndrei.Calc(2011)SfantulAndrei.Calc(2012)Tests: the 2015 and 2016 rows for Ziua Unirii now expect
time.Time{}, and Sfântul Andrei gets a 2011 row (no holiday) and a 2012 row (first year). The 2015, 2016 and 2011 rows fail on master.gofmt -s -l,go vet ./ro/...andgo test -cover ./...pass on Go 1.26.