Skip to content

fix(ro): add start years for Ziua Unirii and Sfântul Andrei #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vicuts wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −12
Open

fix(ro): add start years for Ziua Unirii and Sfântul Andrei #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions v2/ro/ro_holidays.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ var (

// ZiuaUniriiPrincipatelorRomane represents the day when, in 1859, the 2 Romanian principalities, Moldavia and Wallachia, united.
ZiuaUniriiPrincipatelorRomane = &cal.Holiday{
Name: "Ziua Unirii Principatelor Române",
Type: cal.ObservancePublic,
Month: time.January,
Day: 24,
Func: cal.CalcDayOfMonth,
Name: "Ziua Unirii Principatelor Române",
Type: cal.ObservancePublic,
Month: time.January,
Day: 24,
StartYear: 2017,
Func: cal.CalcDayOfMonth,
}

// VinereaMare represents Good Friday - two days before Easter
Expand Down Expand Up @@ -124,11 +125,12 @@ var (

// SfantulAndrei represents Saint Andrew's Day on 30-Nov
SfantulAndrei = &cal.Holiday{
Name: "Sfântul Andrei",
Type: cal.ObservancePublic,
Month: time.November,
Day: 30,
Func: cal.CalcDayOfMonth,
Name: "Sfântul Andrei",
Type: cal.ObservancePublic,
Month: time.November,
Day: 30,
StartYear: 2012,
Func: cal.CalcDayOfMonth,
}

// ZiuaNationala represents Great Union Day on 1-Dec
Expand Down
6 changes: 4 additions & 2 deletions v2/ro/ro_holidays_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ func TestHolidays(t *testing.T) {

{SfantulIon, 2024, d(2024, 1, 7), d(2024, 1, 7)},

{ZiuaUniriiPrincipatelorRomane, 2015, d(2015, 1, 24), d(2015, 1, 24)},
{ZiuaUniriiPrincipatelorRomane, 2016, d(2016, 1, 24), d(2016, 1, 24)},
{ZiuaUniriiPrincipatelorRomane, 2015, time.Time{}, time.Time{}},
{ZiuaUniriiPrincipatelorRomane, 2016, time.Time{}, time.Time{}},
{ZiuaUniriiPrincipatelorRomane, 2017, d(2017, 1, 24), d(2017, 1, 24)},
{ZiuaUniriiPrincipatelorRomane, 2018, d(2018, 1, 24), d(2018, 1, 24)},
{ZiuaUniriiPrincipatelorRomane, 2019, d(2019, 1, 24), d(2019, 1, 24)},
Expand Down Expand Up @@ -148,6 +148,8 @@ func TestHolidays(t *testing.T) {
{AdormireaMaiciiDomnului, 2023, d(2023, 8, 15), d(2023, 8, 15)},
{AdormireaMaiciiDomnului, 2024, d(2024, 8, 15), d(2024, 8, 15)},

{SfantulAndrei, 2011, time.Time{}, time.Time{}},
{SfantulAndrei, 2012, d(2012, 11, 30), d(2012, 11, 30)},
{SfantulAndrei, 2015, d(2015, 11, 30), d(2015, 11, 30)},
{SfantulAndrei, 2016, d(2016, 11, 30), d(2016, 11, 30)},
{SfantulAndrei, 2017, d(2017, 11, 30), d(2017, 11, 30)},
Expand Down