Repository navigation
Conversation
Carve-out 4/6 of the API endpoint review (PR #2697), custody routes: - wallets initialize -> managed-signing/initialize-with-wallet and configs -> managed-signing/configurations; balance aggregate -> wallets/balances/aggregate - fireblocks vault discovery -> vaults/discover (it does not create a vault), credential rollback -> rollback-rotation, connection lifecycle -> cancel-installation/complete-installation - destination eligibility check named for dashboard fireblocks - smoke workflow asks the release's own OpenAPI which wallet-initialize path it serves, so older releases stay exercisable - regenerate catalogs and route snapshots
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
[Medium impact] The PR appears safe to merge, with the previous smoke failure fixed. SummaryRenames wallet signing, balance, and custody setup routes, with matching updates to dashboard callers, docs, catalogs, and tests.
Reviews (2) · Last reviewed commit: "fix(smoke): detect wallet rename via the..." · Reviewed by Greptile |
This was referenced Nov 20, 2026
keeganthomp
requested changes
Nov 20, 2026
keeganthomp
left a comment
Contributor
There was a problem hiding this comment.
The released-image smoke check selects a removed initialization route.
The wallet-initialize path is session-only, so /openapi.json never names it: the has() probe always missed and the smoke kept posting the removed /v1/wallets/initialize. Probe the published managed-signing/configurations route instead, which only a release carrying the rename serves.
cutbow7
added a commit
that referenced
this pull request
Nov 21, 2026
- custody-local.test.ts deploys via /deploy/execute (test correction moved from #2928), unbreaking the Access integration shard - regulated-stablecoin tutorial and regenerated llms-full.txt point authority rotation at /authority/update/execute
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carve-out 4/6 of the API endpoint review (PR #2697), custody routes: