Skip to content

refactor(api): name wallet managed-signing and custody setup routes - #2928

Open
cutbow7 wants to merge 2 commits into
codex/api-review-3-issuancefrom
codex/api-review-4-custody-wallets
Open

cutbow7 wants to merge 2 commits into
codex/api-review-3-issuancefrom
codex/api-review-4-custody-wallets

Conversation

@cutbow7

@cutbow7 cutbow7 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Carve-out 4/6 of the API endpoint review (PR #2697), custody routes:

  • wallets initialize -> managed-signing/initialize-with-wallet and configs -> managed-signing/configurations; balance aggregate -> wallets/balances/aggregate
  • fireblocks vault discovery -> vaults/discover (it does not create a vault), credential rollback -> rollback-rotation, connection lifecycle -> cancel-installation/complete-installation
  • destination eligibility check named for dashboard fireblocks
  • smoke workflow asks the release's own OpenAPI which wallet-initialize path it serves, so older releases stay exercisable
  • regenerate catalogs and route snapshots

Carve-out 4/6 of the API endpoint review (PR #2697), custody routes:
- wallets initialize -> managed-signing/initialize-with-wallet and
  configs -> managed-signing/configurations; balance aggregate ->
  wallets/balances/aggregate
- fireblocks vault discovery -> vaults/discover (it does not create a
  vault), credential rollback -> rollback-rotation, connection
  lifecycle -> cancel-installation/complete-installation
- destination eligibility check named for dashboard fireblocks
- smoke workflow asks the release's own OpenAPI which wallet-initialize
  path it serves, so older releases stay exercisable
- regenerate catalogs and route snapshots
@cutbow7
cutbow7 added this pull request to stack #2927 November 20, 2026 09:28
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sdp-docs Ready Ready Preview Nov 21, 2026 10:49pm UTC
sdp-web Ready Ready Preview Nov 21, 2026 10:49pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
sdp-docs-beta Ignored Ignored Preview Nov 21, 2026 10:49pm UTC
sdp-web-beta Ignored Ignored Preview Nov 21, 2026 10:49pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 1c0014a.

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with the previous smoke failure fixed.

Summary

Renames wallet signing, balance, and custody setup routes, with matching updates to dashboard callers, docs, catalogs, and tests.

  • Wallet routes name managed signing, configuration lists, and balance totals.
  • Dashboard custody paths name vault discovery, lifecycle, and installation actions.
  • The smoke job picks a wallet-initialize path from the release's OpenAPI.
  • Payment and deployment callers use the stacked API's execute routes.

Reviews (2) · Last reviewed commit: "fix(smoke): detect wallet rename via the..." · Reviewed by Greptile

Comment thread .github/workflows/self-hosted-smoke.yml Resolved

@keeganthomp keeganthomp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The released-image smoke check selects a removed initialization route.

Comment thread .github/workflows/self-hosted-smoke.yml Resolved
The wallet-initialize path is session-only, so /openapi.json never
names it: the has() probe always missed and the smoke kept posting the
removed /v1/wallets/initialize. Probe the published
managed-signing/configurations route instead, which only a release
carrying the rename serves.
cutbow7 added a commit that referenced this pull request Nov 21, 2026
- custody-local.test.ts deploys via /deploy/execute (test correction
  moved from #2928), unbreaking the Access integration shard
- regulated-stablecoin tutorial and regenerated llms-full.txt point
  authority rotation at /authority/update/execute

This branch was successfully deployed

2 active deployments
Preview – sdp-web — 1c0014a5 Deployed Nov 21, 2026 by vercel[bot]
Preview – sdp-docs — 1c0014a5 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants