Skip to content

Support more currencies via the Frankfurter v2 API (#449) #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quintushr merged 3 commits into from
Oct 19, 2026
Merged

Support more currencies via the Frankfurter v2 API (#449) #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71042a5
Support more currencies via the Frankfurter v2 API (#449)
quintushr Oct 13, 2026
8d1bf96
Merge branch 'main' into feat/frankfurter-v2-currencies
quintushr Oct 14, 2026
4887790
Fix : type check
quintushr Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions e2e/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,21 +63,18 @@ export const test = base.extend<Options>({
await page.route('https://api.frankfurter.dev/**', (route) => {
if (exchangeRate === null) return route.abort()

// Request shape: /v1/<YYYY-MM-DD>?base=<CODE>. The hook turns the
// response into a RangeError unless `date` echoes the requested date
// exactly, so mirror it back rather than inventing one.
// Request shape: /v2/rates?date=<YYYY-MM-DD>&base=<CODE>&quotes=<CODE>.
// The hook turns the response into a RangeError unless `date` echoes the
// requested date exactly, so mirror it back rather than inventing one.
const url = new URL(route.request().url())
const date = url.pathname.split('/').pop() ?? ''
const date = url.searchParams.get('date') ?? ''
const base = url.searchParams.get('base') ?? ''
const quote = url.searchParams.get('quotes') ?? ''

return route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
base,
date,
rates: { USD: exchangeRate, EUR: exchangeRate, GBP: exchangeRate },
}),
body: JSON.stringify([{ date, base, quote, rate: exchangeRate }]),
})
})

Expand Down
Loading
Loading