Repository navigation
Support more currencies via the Frankfurter v2 API (#449) - #679
Merged
Merged
Conversation
Frankfurter v2 covers 166 currencies instead of v1's ~30, including the ones requested in #418 (TWD), #431 (MOP), #438 (NPR) and #544 (JOD). - useCurrencyRate queries /v2/rates?date=…&base=…"es=… and reads the rate from the returned array. Future dates still come back with the latest available date, so the date-mismatch warning keeps working. - Add the 77 v2 currencies that currency-list has localized data for (the others, e.g. precious metals or currencies without CLDR names, are left out). Existing entries in currency-data.json are kept as they were, so the hand-edited MAD translations from #659 are not overwritten. - Update the e2e Frankfurter mock to the v2 request and response shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
Closed
quintushr
marked this pull request as ready for review
October 14, 2026 01:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frankfurter v2 covers 166 currencies instead of v1's ~30, including the ones requested in #418 (TWD), #431 (MOP), #438 (NPR) and #544 (JOD).
Closes #449
Closes #418
Closes #431
Closes #438
Testing :