Repository navigation
ci: reduce repeated integration test compilation in platform gates - #355
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
FredApps
marked this pull request as ready for review
November 8, 2026 10:34
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce repeated test compilation and linking in the Windows and Ubuntu gates by consolidating engine/UI integration tests into one
itexecutable per crate, alongside the existing standalone session and snapshot targets. Also disable the unused nextest installation through the shared workflow's existingtoolsinput.Evidence
The baseline CI run restored the Rust cache, but Cargo still compiled workspace test executables:
The engine/UI integration executable count drops from 47 to 4. This targets repeated compile/link work; actual wall-clock gains need the draft's hosted gates and can vary with runner/cache conditions.
Coverage and scope
--test sessionand--test ui_snapshots, including the documented hostile-input and snapshot commands.docs/testing-ci.md.The session hostile-input sweep still takes about 5m37s per platform in the baseline. It remains intact; this draft does not claim to remove that runtime cost. The baseline Windows run also spent 88 seconds installing the unused nextest tool; that setup cost varies between runs.
Validation
Passed locally:
cargo fmt --all -- --check,cargo metadata --no-depstarget inspection, moved-source SHA-256 comparison, module-registration inspection, andgit diff --check.No local compilation or runtime tests have been run for this draft. Hosted Ubuntu/Windows gates are required before marking ready; release-profile scoped tests have not been run. Hosted Ubuntu and Windows gates passed on commit 76a8cf5.
Hosted results
CI run: both platform gates passed. Ubuntu gate time fell from 15m36s to 11m47s; Windows from 22m31s to 16m25s (about 24% and 27%). These are individual hosted runs, not controlled benchmarks. CodeQL passed. Packaging lint failed twice downloading actionlint with HTTP 504 before linting; coverage jobs were still running at merge review. No required checks were reported by GitHub.