Skip to content

Skip symlink tests when Windows blocks symlink creation - #39

Merged
unshDee merged 1 commit into
unshDee:mainfrom
Nandaninaulaa:codex/windows-symlink-test-compat
Nov 5, 2026
Merged

unshDee merged 1 commit into
unshDee:mainfrom
Nandaninaulaa:codex/windows-symlink-test-compat

Conversation

@Nandaninaulaa

Copy link
Copy Markdown
Contributor

Summary

  • Add a shared symlink_or_skip fixture for tests that require symlinks.
  • Skip only when Windows returns ERROR_PRIVILEGE_NOT_HELD (WinError 1314), which occurs when Developer Mode or the required privilege is unavailable.
  • Preserve the existing symlink security assertions on platforms and Windows setups that permit symlink creation.

Validation

  • The four affected tests: 4 skipped as expected on this Windows machine, which does not grant symlink creation privileges.
  • python devtools/lint.py — passed
  • Ruff, formatting, basedpyright, and git diff --check — passed

@unshDee
unshDee merged commit 9a5a7a9 into unshDee:main Nov 5, 2026
4 checks passed

unshDee commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Merged, thanks @Nandaninaulaa! Clean, well-scoped change.


Generated by Claude Code

unshDee added a commit that referenced this pull request Nov 14, 2026
## Summary

Adds `[Unreleased]` CHANGELOG entries for the three contributor PRs
merged last week, which didn't include any:

- **Added:** the LlamaIndex (#38) and LangChain
(#36) adapter examples
- **Fixed:** symlink tests skip instead of failing on Windows without
symlink privileges (#39)

The hit_rate@k metric (#37) is left out until that PR
merges.

## Type

- [ ] feat — new capability
- [ ] fix — bug fix
- [x] docs — documentation only
- [ ] chore / refactor / test

## Checklist

- [x] `make lint` passes
- [ ] `make test` passes (CHANGELOG only; no code changed)
- [x] Updated `CHANGELOG.md` under `## [Unreleased]` (if user-facing)
- [ ] Updated docs / `SKILL.md` if behavior or commands changed (n/a)

https://claude.ai/code/session_01VUZBF9vuw7vzzXQ3d4YZCG

---
_Generated by [Claude Code](https://claude.ai/code)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants