Repository navigation
Conversation
…ault task image ax-server used to fall back to a server-wide default task image when a Task's profile set neither image nor ateTemplate.name. That default, v1alpha1.DefaultTaskImage, had no @sha256 digest and pointed at a private repo, so Substrate rejected it unless an operator overrode it with --default-task-image / AX_DEFAULT_TASK_IMAGE. Remove the default and require every task to say what it runs. API - Task.spec.profile is now required and must set image or ateTemplate.name (apivalidation.ValidateTask). - When pre-warming is enabled, a Workspace with a profile or setup steps must set spec.profile.image or ateTemplate.name (ValidateWorkspacePrewarm). - Workspace.spec.profile is no longer a fallback profile for Tasks. It is only used to pre-warm the workspace snapshot. Update the task.proto and workspace.proto comments and docs/manifests.md. Server and controller - Remove v1alpha1.DefaultTaskImage, the ax-server --default-task-image flag, AX_DEFAULT_TASK_IMAGE, and the defaultTaskImage plumbing through TaskReconciler, WorkspaceManager, ResolveProfileTemplate, and substrate.BuildActorTemplate. - Tasks stored before this change that resolve to no image now fail with TemplateCreationFailed. They no longer run a default image. Install and release - Remove --default-task-image from ax install / ax local start, and remove AX_DEFAULT_TASK_IMAGE from deploy/ax-server.yaml, the deploy renderer, and axdeploy. - Rename the release output AX_DEFAULT_TASK_IMAGE to AX_TASK_RUNNER_IMAGE. `make images` now prints the digest-pinned ax-task-runner ref to use as spec.profile.image. - Update README, docs, demo.sh, the E2E harness, and manifests to match.
aojea
approved these changes
Nov 19, 2026
aojea
left a comment
Collaborator
There was a problem hiding this comment.
I assume that at this point we do not worry much about compatibility based on the v1alpha1 group so changes are mostly mechanical s/default_image/profile/ with validation in place to ensure the image is set in the profile
YoyinZyc
reviewed
Nov 19, 2026
mayawang
approved these changes
Nov 19, 2026
mayawang
left a comment
Collaborator
There was a problem hiding this comment.
LGTM on dropping the default image, an undigested private default was never going to work. Yuchen's inheritance question is the one to settle before we tag, since it's the v1alpha1 contract. Heads up that hack/hero-demo/workspace.yaml has setup but no profile, so it'll fail ValidateWorkspacePrewarm once prewarm is on
Resolve conflicts with main (ensureProfileTemplate refactor, removal of firstUnimplementedWorkspaceField, Studio docs) and address review: - Keep inheritance: a Task that omits spec.profile uses its bound Workspace's profile. ValidateTask requires spec.profile only when the Task binds no Workspace; CreateTask rejects a Task whose Workspace has no profile to inherit. - Fold the image check into validateProfile: a set profile must name image or ateTemplate.name. - Replace ValidateWorkspacePrewarm with a check in ValidateWorkspace: a Workspace with setup steps must set a profile, whether or not pre-warming is enabled. - Give the README, claude-code example, E2E and unit-test Workspaces with setup steps a profile.
Member
Author
|
PTAL |
YoyinZyc
approved these changes
Nov 20, 2026
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ax-server used to fall back to a server-wide default task image when a Task's profile set neither image nor ateTemplate.name. That default, v1alpha1.DefaultTaskImage, had no @sha256 digest and pointed at a private repo, so Substrate rejected it unless an operator overrode it with --default-task-image / AX_DEFAULT_TASK_IMAGE. Remove the default: every task now runs an image it names, directly or through its Workspace.
API
Server and controller
Install and release
make imagesnow prints the digest-pinned ax-task-runner ref to use as spec.profile.image.Examples, docs, and tests